fix(third-party): cap lints on vendored wait-timeout #36

Merged

patman merged 1 commit from patman/wait-timeout-cap-lints into main

2026-07-09 23:11:17 +00:00

patman commented

2026-06-27 04:15:10 +00:00

Owner

What this does

Adds a reindeer fixup capping lints (--cap-lints=allow) on the vendored wait-timeout 0.2.1 crate.

wait-timeout carries #![deny(warnings)]; rustc 1.96 introduced the function_casts_as_integer lint (implied by deny(warnings)), which turns a sigchld_handler as usize cast in its unix.rs into a hard error. This broke every buck2 test target, since proptest pulls wait-timeout in transitively via its fork/timeout features. The library (//common:common) was unaffected.

Capping lints on the vendored crate is the standard fix — we should not enforce our lint policy on third-party code.

Stack position

PR 1 of 2. Next: feat(units): back unit newtypes with uom, which depends on this so its tests can run.

Review focus

The one-line fixup; regenerated BUCK adds rustc_flags = ["--cap-lints=allow"] to the wait-timeout target.

## What this does Adds a reindeer fixup capping lints (`--cap-lints=allow`) on the vendored `wait-timeout 0.2.1` crate. `wait-timeout` carries `#![deny(warnings)]`; rustc 1.96 introduced the `function_casts_as_integer` lint (implied by `deny(warnings)`), which turns a `sigchld_handler as usize` cast in its `unix.rs` into a hard error. This broke **every** `buck2 test` target, since `proptest` pulls `wait-timeout` in transitively via its `fork`/`timeout` features. The library (`//common:common`) was unaffected. Capping lints on the vendored crate is the standard fix — we should not enforce our lint policy on third-party code. ## Stack position PR 1 of 2. Next: `feat(units): back unit newtypes with uom`, which depends on this so its tests can run. ## Review focus The one-line fixup; regenerated `BUCK` adds `rustc_flags = ["--cap-lints=allow"]` to the wait-timeout target.

patman added 1 commit

2026-06-27 04:15:10 +00:00

fix(third-party): cap lints on vendored wait-timeout 5926951623

wait-timeout 0.2.1 carries #![deny(warnings)]; rustc 1.96's new
function_casts_as_integer lint turns that into a hard error, breaking
every buck2 test target (proptest pulls wait-timeout in via its
fork/timeout features). Add a reindeer fixup that caps lints on the
vendored crate so toolchain bumps don't break the build.

Co-authored-by: patman-assist <patrick-ai@kgroo.co>